Make upgrade and update minimum Go version to 1.21 #3123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
bufdev
changed the title
|
FYI @doriable @oliversun9 @pkwarren I'm keeping this branch up to date in anticipation of 1.23 release, ignoring other dependabots for now |
This was referenced Aug 1, 2024
As a quick follow-up to #3124 and in response to #3124 (comment), this adds a `clean` config key to `v2` `buf.gen.yaml`, for example: ```yaml version: v2 clean: true plugins: - local: custom-gen-go out: gen/go opt: paths=source_relative strategy: directory - protoc_builtin: java out: gen/java ``` When running `buf generate` with the above configs, the outs set to each plugin (e.g. `gen/go` and `gen/java`) will be removed before code generation is run. If `buf generate --clean` flag is set, then that will always take precedence, even if `clean: false` in the configuration. And likewise, if `buf generate --clean=false`, and `clean: true` in the configuration, then we would not delete the out directories. --------- Co-authored-by: Oliver Sun <73540835+oliversun9@users.noreply.github.com> Co-authored-by: Oliver Sun <osun@buf.build> Co-authored-by: bufdev <4228796+bufdev@users.noreply.github.com> Co-authored-by: bufdev <bufdev-github@buf.build>
This was referenced Aug 12, 2024
|
Likely relies on golangci/golangci-lint#4836 being merged. Also https://hub.docker.com/_/golang needs |
|
Docker updated in docker-library/golang#529, just waiting on |
|
Actually now need docker-library/official-images#17359. |
smallsamantha
approved these changes
Aug 13, 2024
oliversun9
approved these changes
Aug 13, 2024
|
Temporarily downgrading the Docker images to 1.22 until the 1.23 images are available - this actually has no effect since |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is practically ready for merge once 1.23 is released. Do a
make upgradebefore merging.